Skip to content

OAuth 2.0 integration#351

Merged
yadvr merged 3 commits intoapache:mainfrom
shapeblue:oauth
Oct 30, 2023
Merged

OAuth 2.0 integration#351
yadvr merged 3 commits intoapache:mainfrom
shapeblue:oauth

Conversation

@harikrishna-patnala
Copy link
Member

@harikrishna-patnala harikrishna-patnala commented Sep 29, 2023 •
edited
Loading

This is related to the PR apache/cloudstack#7996

oauth-login

@harikrishna-patnala
Copy link
Member Author

harikrishna-patnala commented Sep 29, 2023

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Sep 29, 2023

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Sep 29, 2023

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/351. (QA-JID 133)

@harikrishna-patnala harikrishna-patnala mentioned this pull request Sep 29, 2023
Merged
12 tasks
DaanHoogland
DaanHoogland approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text looks good @harikrishna-patnala , but does it make sense to add API based configuration instructions?

@shwstppr shwstppr added this to the 4.19.0.0 milestone Sep 29, 2023
@harikrishna-patnala
Copy link
Member Author

harikrishna-patnala commented Sep 29, 2023

@blueorangutan docbuild

@harikrishna-patnala
Copy link
Member Author

harikrishna-patnala commented Sep 29, 2023

text looks good @harikrishna-patnala , but does it make sense to add API based configuration instructions?

Okay @DaanHoogland I think not all are APIs are required, but registerOAuthProvider makes sense to add. I'll add it.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 2, 2023

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Oct 2, 2023

@DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 2, 2023

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/351. (QA-JID 137)

@harikrishna-patnala
Copy link
Member Author

harikrishna-patnala commented Oct 20, 2023

@blueorangutan docbuild

@blueorangutan
Copy link

blueorangutan commented Oct 20, 2023

@harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Oct 20, 2023

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/351. (QA-JID 153)

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Oct 20, 2023

@harikrishna-patnala why do we need two pictures of the login page with "testdomain"? these could be shared right?

yadvr
yadvr approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit b7b215d into apache:main Oct 30, 2023
@yadvr yadvr deleted the oauth branch October 30, 2023 11:54
@yadvr
Copy link
Member

yadvr commented Oct 30, 2023

@harikrishna-patnala if there any further changes, pl raise another doc PR and ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19

Development

Successfully merging this pull request may close these issues.

5 participants

@harikrishna-patnala @blueorangutan @DaanHoogland @yadvr @shwstppr