remove Juniper plugin references#348
Merged
DaanHoogland merged 5 commits intoapache:mainfrom Dec 6, 2023
Merged
Conversation
Contributor
|
@blueorangutan docbuild |
|
@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/348. (QA-JID 136) |
Contributor
Author
|
is this lgty @shwstppr ? |
Member
|
@blueorangutan docbuild |
|
@rohityadavcloud a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
DaanHoogland
commented
Dec 1, 2023
source/adminguide/networking/external_firewalls_and_load_balancers.rst
Outdated
Show resolved
Hide resolved
shwstppr
approved these changes
Dec 6, 2023
Contributor
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
LGTM, makes sense to remove
source/adminguide/networking/external_firewalls_and_load_balancers.rst
Outdated
Show resolved
Hide resolved
source/adminguide/networking/external_firewalls_and_load_balancers.rst
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM, I reworded it a bit, but good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a bit hard to define which are just plugin references and which are architectural best practices.
this implements cloudstack#7690
📚 Documentation preview 📚: https://cloudstack-documentation--348.org.readthedocs.build/en/348/