Changing executeAPI to utilize POST request#18
Merged
yadvr merged 7 commits intoapache:mainfrom Jul 14, 2025
Merged
Conversation
yadvr
reviewed
Apr 16, 2025
Contributor
Author
|
This should have resolved the changes |
14 tasks
kiranchavala
approved these changes
Jun 12, 2025
Collaborator
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM, tested by building the cs-bench binary locally
-
Clone the Cloudstack go repo and cloudstack csbench repo
-
Navigate into cs bench repo
-
vi go.mod
replace http://github.com/apache/cloudstack-go/v2 => /Users/kiranchavala/Desktop/cloudstack-go -
go mod tidy
-
go build
-
Set the global setting value to true for enforce.post.requests.and.timestamps
-
./csbench -create -domain -limits -network -vm -volume
The tool worked successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing executeAPI to utilize POST request