Skip to content

Optimize null bitmap handling for better append performance #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize null bitmap handling for better append performance #1384

wants to merge 1 commit into from
+57 −18

Conversation

gongxun0928
Copy link
Contributor

  1. Pre-allocate null bitmap capacity to pax_max_tuples_per_group to avoid capacity checks
  2. initialize null bitmap with all bits set to 1 (0xff) by default, assuming non-null values are more frequent

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions

@gongxun0928
Optimize null bitmap handling for better append performance
23efe15 
1. Pre-allocate null bitmap capacity to pax_max_tuples_per_group to avoid
capacity checks
2. initialize null bitmap with all bits set to 1 (0xff) by default, assuming
non-null values are more frequent
my-ship-it
my-ship-it approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

@jiaqizho jiaqizho Awaiting requested review from jiaqizho

@gfphoenix78 gfphoenix78 Awaiting requested review from gfphoenix78

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gongxun0928 @my-ship-it