Skip to content

Remove unused variable in foreign.c #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused variable in foreign.c #1381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/backend/foreign/foreign.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,6 @@ GetForeignTableOnSegment(Oid relid)
SysScanDesc ftscan;
HeapTuple fttuple;
int i;
int segNumber;

segNumber = GetForeignTableSegNumbers(relid);
Comment on lines -422 to -424
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codes are introduced by CBDB at commit ed64982,

It looks like the intent to update ForeignTable.num_segments was missed or forgotten in this block, specifically around line 440. Instead of deleting the logic, we should ensure ForeignTable.num_segments is assigned the correct value there.

cc @oppenheimer01


foreignTableRel = table_open(ForeignTableRelationSegId, AccessShareLock);

Expand Down