Skip to content

Cherry pick ic commits from gp7 #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+448 −388
Open

Cherry pick ic commits from gp7 #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
058bd2b
Disregard dtx when pruning IC history (#13355)
xuebinsu Apr 19, 2022
a4790e5
UDP interconnect: Modernize IC socket setup
soumyadeep2007 Jun 10, 2022
bcaebad
Enhance prune behavior of IC_HISTROY_TABLE for the read-only transact…
interma Oct 8, 2023
8260a26
Remove `getaddrinfo` in `SendDummyPacket()` to address malloc deadlock
Chibin Aug 24, 2023
7d9539f
Accommodate for AF_INET6 when doing a motion layer IPC teardown
Chibin Sep 25, 2023
7deb6bb
Make sendControlMessage to retry when interrupted (#13371)
Aegeaner Apr 27, 2022
22c2bf4
Add hint message for MTU settings when IC reports ERROR "Failed to se…
z-wenlin Apr 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions contrib/interconnect/udp/ic_faultinjection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ typedef enum {
FINC_OS_NET_INTERFACE = 19,
FINC_OS_MEM_INTERFACE = 20,
FINC_OS_CREATE_THREAD = 21,
FINC_PKT_TOO_LONG = 22,

/* These are used to inject network faults. */
FINC_NET_RECV_ERROR = 23,
Expand Down Expand Up @@ -301,6 +302,13 @@ testmode_sendto(const char *caller_name, int socket, const void *buffer,
errno = EFAULT;
return -1;

case FINC_PKT_TOO_LONG:
if (!FINC_HAS_FAULT(fault_type) || !is_pkt)
break;
write_log("inject fault to sendto: FINC_PKT_TOO_LONG");
errno = EMSGSIZE;
return -1;

default:
break;
}
Expand Down Expand Up @@ -481,25 +489,6 @@ testmode_getsockname(const char *caller_name, int socket,
return getsockname(socket, address, address_len);
}

/*
* testmode_getsockopt
* getsockopt function with faults injected
*/
static int
testmode_getsockopt(const char *caller_name, int socket, int level,
int option_name, void *restrict option_value,
socklen_t *restrict option_len)
{
if (FINC_HAS_FAULT(FINC_OS_NET_INTERFACE) &&
testmode_inject_fault(gp_udpic_fault_inject_percent))
{
write_log("inject fault to getsockopt: FINC_OS_NET_INTERFACE");
errno = EFAULT;
return -1;
}

return getsockopt(socket, level, option_name, option_value, option_len);
}

/*
* testmode_setsockopt
Expand Down Expand Up @@ -657,9 +646,6 @@ testmode_pthread_create(const char *caller_name, pthread_t *thread,
#define getsockname(socket, address, address_len) \
testmode_getsockname(PG_FUNCNAME_MACRO, socket, address, address_len)

#define getsockopt(socket, level, option_name, option_value, option_len) \
testmode_getsockopt(PG_FUNCNAME_MACRO, socket, level, option_name, option_value, option_len)

#define setsockopt(socket, level, option_name, option_value, option_len) \
testmode_setsockopt(PG_FUNCNAME_MACRO, socket, level, option_name, option_value, option_len)

Expand Down
Loading
Loading