postgres_fdw: add missing test files and fix regression tests #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for adding those tests back |
|
Add running tests to regular CI so that we can protect it? |
yjhjstz
reviewed
Jul 8, 2025
|
|
||
| PG_CPPFLAGS = -I$(libpq_srcdir) | ||
| SHLIB_LINK_INTERNAL = -Wl,-Bsymbolic -Wl,-Bstatic -Wl,-Bstatic $(libpq) -Wl,-Bdynamic | ||
| SHLIB_LINK_INTERNAL = $(libpq) |
Some essential files such as postgres_setup.bash and *_postgres_init.sql were missing, causing postgres_fdw regression tests to fail. These files existed in upstream GPDB. We restored them and fixed the tests so that all cases now pass.
roseduan
force-pushed
the
add_postgres_fdw_test_script
branch
from
e3dc13c to
c11c286
Compare
Can we add postgres_fdw to our CI ? @edespino |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some essential files such as postgres_setup.bash and *_postgres_init.sql were missing, causing postgres_fdw regression tests to fail. These files existed in upstream GPDB.
We restored them and fixed the tests so that all cases now pass.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions