Skip to content

Commit

Permalink
[CELEBORN-1578] Make Worker#timer have thread name and daemon
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

### Why are the changes needed?
Current jstack
```java
"pool-36-thread-1" #118 prio=5 os_prio=0 tid=0x00007f40cc00d000 nid=0xd3e0 waiting on condition [0x00007f3ecbffe000]
   java.lang.Thread.State: TIMED_WAITING (sleeping)
        at java.lang.Thread.sleep(Native Method)
        at io.netty.util.HashedWheelTimer$Worker.waitForNextTick(HashedWheelTimer.java:600)
        at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:496)
        at java.lang.Thread.run(Thread.java:745)
```

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
GA

Closes #2704 from cxzl25/CELEBORN-1578.

Lead-authored-by: sychen <sychen@ctrip.com>
Co-authored-by: cxzl25 <3898450+cxzl25@users.noreply.github.com>
Signed-off-by: SteNicholas <programgeek@163.com>
(cherry picked from commit 5c83965)
Signed-off-by: SteNicholas <programgeek@163.com>
  • Loading branch information
2 people authored and SteNicholas committed Aug 28, 2024
1 parent 822701f commit 706dda7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ private[celeborn] class Worker(
conf.workerCleanThreads)
val asyncReplyPool: ScheduledExecutorService =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("worker-rpc-async-replier")
val timer = new HashedWheelTimer()
val timer = new HashedWheelTimer(ThreadUtils.namedSingleThreadFactory("worker-timer"))

// Configs
private val heartbeatInterval = conf.workerHeartbeatTimeout / 4
Expand Down

0 comments on commit 706dda7

Please sign in to comment.