CASSANDRA-20636 - Fix: handle MAX_SEGMENT_SIZE < chunkSize for MmappedRegions::updateState

[samueldlightfoot]

• Fix: handle MAX_SEGMENT_SIZE < chunkSize for MmappedRegions::updateState
• Resolve ref leaks seen in SSTableReaderTest

Targeting 5.0

patch by Sam Lightfoot; reviewed by <> for CASSANDRA-20636

https://issues.apache.org/jira/browse/CASSANDRA-20636

[szymon-miezal]

The fix makes sense to me, I have allowed myself to add a small test that verifies and documents the case when max segment size is smaller than page size - szymon-miezal@b444c66, what do you think?

[samueldlightfoot]

The fix makes sense to me, I have allowed myself to add a small test that verifies and documents the case when max segment size is smaller than page size - szymon-miezal@b444c66, what do you think?

LGTM, thank you - pushed up.

[michaelsembwever]

i can't get this to compile

    [javac] /home/build/cassandra/test/unit/org/apache/cassandra/io/sstable/SSTableReaderTest.java:45: error: package org.junit.jupiter.api does not exist
    [javac] import org.junit.jupiter.api.Assertions;

just me ?

[szymon-miezal]

@michaelsembwever it fails on my machine as well (C* does not depend on jupiter it seems), szymon-miezal@d476614 should fix it.

[samueldlightfoot]

Pushed through, thanks Szymon.

[samueldlightfoot]

Commited 53ccfd5