add the constructor NewNativeType #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test an implementation of
gocql.Unmarshalerorgocql.MarshalerI need to pass it agocql.TypeInfo.Until today I just did that indirectly by creating tables and querying cassandra directly, but it's taking a long time to spin up a Cassandra for my CI builds.
So I looked at a way to build the
gocql.TypeInfomyself, and turns out the interface is not that complicated so I made my own type for it.But, it's kind of a waste because I ended up duplicating this, and my TypeInfo was basically just this copied.
NativeTypeis the only type with fields not exposed so I can't use it directly, which is why I'm suggesting creating a constructorNewNativeTypefor it. Or we could expose all fields but that's more invasive work.