If DisableInitialHostLookup, Update Hosts On First Ring Refresh #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If DisableInitialHostLookup is enabled, the Host IDs are random UUIDs. Therefore, on the first ring refresh, remove the hosts and re-add them back and refill the pools. Closes apache#1721
|
Hi! Thanks for the pull request! In general the change looks good to me. Could you please update AUTHORS file as per CONTRIBUTING.md? Also it seems that some tests are now failing. Could you please check them? I wonder if we could also add a test case to ensure that #1721 does not re-occur later. Maybe something like |
|
@martin-sucha Alright, I believe the tests should be passing now, and I added an integration test |
|
Hey there @martin-sucha, any chance you could take a look at this for merge? Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If DisableInitialHostLookup is enabled, the Host IDs are random UUIDs. Therefore, on the first ring refresh, remove the hosts and re-add them back and refill the pools.
Closes #1721