Start errors with lowercase letter #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-sucha
force-pushed
the
lowercase-errors
branch
from
5393dd6 to
eb7c72e
Compare
matoous
approved these changes
Jan 25, 2021
Error messages shouldn't be capitalized. https://github.com/golang/go/wiki/CodeReviewComments#error-strings
martin-sucha
force-pushed
the
lowercase-errors
branch
from
eb7c72e to
9e3bb6c
Compare
martin-sucha
added a commit
to kiwicom/gocql
that referenced
this pull request
Jan 29, 2021
Jaume Marhuenda (3):
fix compileMetadata bug for materialized views (apache#1525)
Add myself to AUTHORS (apache#1527)
fix compileMetadata bug for aggregate views (apache#1528)
Martin Sucha (5):
Fix TLS host verification when ServerName is not provided in TLS
config
Document type conversions for Marshal and Unmarshal
Start errors with lowercase letter (apache#1506)
Merge Tuple unmarshaling improvements (apache#1529)
Use the same host iterator in speculative execution
Piotr Dulikowski (4):
tuple_test: check unmarshaled results in nested collection test
fix deserialization of nested tuples with nullable elements
fix unmarshaling of last empty/nil field in tuple
add myself to AUTHORS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error messages shouldn't be capitalized.
https://github.com/golang/go/wiki/CodeReviewComments#error-strings