error if can't retry on more hosts #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beltran
changed the title
beltran
force-pushed
the
error_if_no_more_hosts
branch
from
1cd1e2f to
ffb9c15
Compare
alourie
suggested changes
Oct 11, 2018
| @@ -152,6 +152,9 @@ func (q *queryExecutor) run(qry ExecutableQuery, specWG *sync.WaitGroup, results | |||
| case RetryNextHost: | |||
| // retry on the next host | |||
| selectedHost = hostIter() | |||
| if selectedHost == nil { | |||
| results <- queryResponse{iter: iter} | |||
| } | |||
There was a problem hiding this comment.
right, I thought it's covered but the main loop....so to avoid confusion, let's return after this. Alternatively, we can move the channel loading to after the loop, and check if the iter pointer is not nil, then push it to the results channel. I actually have no preference here on one way or the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking tests in master. Can you review @alourie ?