Improve query pool #1104
Merged
Improve query pool #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so the lock hold time is shortened.
while modern Go compilers should combine all those stores to an more efficient clearing, lets be explicit here and have a little simpler code. This also makes it impossible to forget any newly added fields.
so we don't miss any settings, like missing Query.serialCons and Query.defaultTimestamp in the Session.Bind method.
so in stays consistent in the future between Session.Bind and Session.Query.
|
Hi all, |
Zariel
reviewed
May 5, 2018
| q.cons = 0 | ||
| q.pageSize = 0 | ||
| q.routingKey = nil | ||
| q.routingKeyBuffer = nil |
There was a problem hiding this comment.
looking at this, we could probably keep these buffers between pooling but would need to verify that they are not kept around anywhere after being used.
Zariel
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So query creation is more efficient as well as as identical as possible in Session.Bind and Session.Query.