restrict refresh ring to heartBeat #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'nodetool settraceprobability' is used, it's possible to get a response with trace information even though client did not specifically mark the query for tracing.
Conflicts: AUTHORS
GetHosts uses queries on control connection. Any query error will cause reconnection and refresh ring which calls GetHosts and thus deadlocks. Also it seems neater to have the ring refresh be done only by heartBeat. Fixes apache#928
|
@Zariel - any comments on the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetHosts uses queries on control connection. Any query error will
cause reconnection and refresh ring which calls GetHosts and thus
deadlocks.
Also it seems neater to have the ring refresh be done only by heartBeat.
Fixes #928
Verified that all tests that pass continue to pass with the fix.
Refer to issue #928 for details about this PR