CASSANDRA-20883: fixed a bug with the bit set when querying outside of the size #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
commented
Sep 8, 2025
| private int nextSetBitInternal(int i, int exclIndexBound, int ifNotFound) | ||
| { | ||
| Invariants.requireArgument(i >= 0); | ||
| Invariants.requireArgument(i <= size()); |
There was a problem hiding this comment.
the interface doesn't expose a way to know the size, so you need to rely on nextSetBitInternal to know when to complete iterating, so rather than failing return -1
There was a problem hiding this comment.
My only concern here is that this is inconsistent with get/set etc. We should either consistently change all of these methods to support indexes outside of the range, or we should retain the existing behaviour and simply expose capacity() in the interface. I don't have a strong opinion, though I lean towards the capacity() approach as it is is more likely than not to be a bug to access outside of the allocated range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.