feat: fix encoding for Windows tasklist output in IsWindowTitleActive() - #132
Merged
Conversation
|
|
nomeguy
marked this pull request as ready for review
November 19, 2025 15:06
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix wrong encoding for IsWindowTitleActive() output
Fix encoding for Windows tasklist output in IsWindowTitleActive()
Nov 19, 2025
hsluoyz
added a commit
that referenced
this pull request
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows
tasklistcommand outputs text in the system's default codepage (typically GBK for Chinese systems), but Go reads it as UTF-8, causing garbled text that breaks string comparison with window titles.Changes
tasklistoutput from GBK to UTF-8 usinggolang.org/x/text/encoding/simplifiedchineseThis allows the function to correctly match window titles containing non-ASCII characters.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.