[CARBONDATA-850] Fix the comment definition issues of CarbonData thrift files #729
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@ravipesala please review it, and please remember to deploy format jar to snapshot repo. |
| 1: required ChunkCompressionMeta chunk_meta; // the metadata of a chunk | ||
| 2: required bool rowMajor; // whether this chunk is a row chunk or column chunk ? Decide whether this can be replace with counting od columnIDs | ||
| 1: required ChunkCompressionMeta chunk_meta; // The metadata of a chunk | ||
| 2: required bool rowMajor; // Whether this chunk is a row chunk or column chunk, Decide whether this can be replace with counting of columnIDs. |
There was a problem hiding this comment.
Decide whether this can be replace with counting of columnIDs we can remove this part as we are deciding based on the schema file.
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1415/ |
| */ | ||
|
|
||
| /** | ||
| * File format description for the carbon file format | ||
| * File format description for CarbonData index file, one node one carbonindex file for building driver side's index tree. |
There was a problem hiding this comment.
I guess it is not required to mention that one node one carbonindex file for building driver side's index tree as it can change depends up on loading algorithm. In batch sort it creates one index file for one batch. And in the same way for bucket loading it creates one index file for each bucket and node.
We can just say that one index file for btree.
| * Represents the data of one dimension one dimension group in one blocklet | ||
| */ | ||
| // add a innger level placeholder for further I/O granulatity | ||
| * Represents the data of one column page or one column page group in one blocklet. |
There was a problem hiding this comment.
Better phrase as follow.
Represents the data of one column page or one column page group in side blocklet.
There was a problem hiding this comment.
And also we can mention that we are currently not using it, we keep it as for future extend ability.
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1420/ |
|
LGTM |
Fix the comment definition issues of CarbonData thrift files, for helping users to easier understand CarbonData file format.