[CARBONDATA-847] Fixed NullPointerException for DictionaryBasedVectorResultCollector during alter table #724
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1407/ |
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1409/ |
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1410/ |
| @@ -51,8 +51,8 @@ | |||
|
|
|||
| public DictionaryBasedVectorResultCollector(BlockExecutionInfo blockExecutionInfos) { | |||
| super(blockExecutionInfos); | |||
| queryDimensions = tableBlockExecutionInfos.getQueryDimensions(); | |||
| queryMeasures = tableBlockExecutionInfos.getQueryMeasures(); | |||
| queryDimensions = tableBlockExecutionInfos.getActualQueryDimensions(); | |||
There was a problem hiding this comment.
Why getting actualQueryDimensions instead of queryDimensions in DictionaryBasedVectorResultCollector? But we get only queryDimensions in DictionaryBasedResultCollector
There was a problem hiding this comment.
getQueryDimensions or getQueryMeasures do not contain the newly added columns so when we try to get the vector from allColumnInfo which has the size [measures + dimensions] we would get a ArrayIndexOutOfBoundException because it will not have the space for the new column.
There was a problem hiding this comment.
I did not get, if any restructuring is required then it supposed to go to RestructureBasedVectorResultCollector class right. why it comes here.
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1438/ |
… during alter table
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1484/ |
|
LGTM |
No description provided.