Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-839] Fixed issue with meta lock not getting deleted for rename table #717

Closed
wants to merge 1 commit into from
Closed

[CARBONDATA-839] Fixed issue with meta lock not getting deleted for rename table #717

wants to merge 1 commit into from

Conversation

kunal642
Copy link
Contributor

The following things are fixed in this patch:

  1. Meta lock location has been changed from "tmp" to table store location.
  2. The meta lock file was not being delete when the lock was released in case of table rename because the path stored in the lock would not be updated along with the table rename. To fix this, a new method to manually delete the lock file has been added in AbstractCarbonLock.

@asfbot
Copy link

asfbot commented Mar 31, 2017

Can one of the admins verify this patch?

2 similar comments
@asfbot
Copy link

asfbot commented Mar 31, 2017

Can one of the admins verify this patch?

@asfbot
Copy link

asfbot commented Mar 31, 2017

Can one of the admins verify this patch?

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1398/

ravipesala
ravipesala reviewed Apr 5, 2017
View reviewed changes
core/src/main/java/org/apache/carbondata/core/locks/LocalFileLock.java
@@ -70,7 +71,8 @@
LogServiceFactory.getLogService(LocalFileLock.class.getName());

static {
tmpPath = System.getProperty("java.io.tmpdir");
tmpPath = CarbonProperties.getInstance().getProperty(CarbonCommonConstants.STORE_LOCATION,
System.getProperty("java.io.tmpdir"));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if my store location is hdfs? how it can create lock there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a HDFS store location, HdfsFileLock would be called instead of LocalFileLock

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still that code is not yet merged. it is present in https://github.com/apache/incubator-carbondata/pull/736

ravipesala
ravipesala reviewed Apr 5, 2017
View reviewed changes
core/src/main/java/org/apache/carbondata/core/locks/ICarbonLock.java Outdated
@@ -36,4 +36,6 @@
*/
boolean lockWithRetries();

boolean releaseLockManually(String lockFile);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1429/

@kunal642
Copy link
Contributor Author

kunal642 commented Apr 5, 2017

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1432/

@kunal642 kunal642 closed this Apr 5, 2017
@kunal642 kunal642 reopened this Apr 5, 2017
@asfbot
Copy link

asfbot commented Apr 5, 2017

Can one of the admins verify this patch?

2 similar comments
@asfbot
Copy link

asfbot commented Apr 5, 2017

Can one of the admins verify this patch?

@asfbot
Copy link

asfbot commented Apr 5, 2017

Can one of the admins verify this patch?

@kunal642
Copy link
Contributor Author

kunal642 commented Apr 5, 2017

@ravipesala Added comments. Please review

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1471/

@CarbonDataQA
Copy link

Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1472/

@ravipesala
Copy link
Contributor

LGTM

@asfgit asfgit closed this in fa7421a Apr 6, 2017
@kunal642 kunal642 deleted the CARBONDATA-839 branch April 6, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravipesala ravipesala ravipesala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kunal642 @asfbot @CarbonDataQA @ravipesala