[CARBONDATA-795]rename table is changing provided db to current db #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Failed with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1230/ |
|
retest this please |
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1233/ |
nareshpr
force-pushed
the
renametablefix
branch
from
0642d26
to
e41f66e
Compare
gvramana
approved these changes
Mar 20, 2017
| @@ -174,7 +175,7 @@ private[sql] case class AlterTableRenameTable(alterTableRenameModel: AlterTableR | |||
| CarbonEnv.get.carbonMetastore.removeTableFromMetadata(oldDatabaseName, oldTableName) | |||
| sparkSession.sharedState.externalCatalog.asInstanceOf[HiveExternalCatalog].client | |||
| .runSqlHive( | |||
| s"ALTER TABLE $oldDatabaseName.$oldTableName RENAME TO $newTableName") | |||
| s"ALTER TABLE $oldDatabaseName.$oldTableName RENAME TO $newDatabaseName.$newTableName") | |||
There was a problem hiding this comment.
Change this to oldDatabaseName
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1237/ |
|
retest this please |
|
Build Success with Spark 1.6.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/1240/ |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user trigger rename table command not on current database, table is getting renamed from provided db to current db.
eg., alter table testdb.test1 rename to testdb.test2
Assume current db is default,
Above query is renaming the table from testdb.test1 to default.test2