[CARBONDATA-410] added test case for file system #317
Conversation
| Configuration config = new Configuration(); | ||
| //adding local hadoop configuration | ||
| config.addResource(new Path("/usr/local/Cellar/hadoop/2.4.0/libexec/etc/hadoop/core-site.xml")); | ||
| config.addResource(new Path("/usr/local/Cellar/hadoop/2.4.0/libexec/etc/hadoop/hdfs-site.xml")); |
There was a problem hiding this comment.
please change this configuration file to relative path.
There was a problem hiding this comment.
@Hexiaoqiao i have done changes can you have a look?
| } | ||
|
|
||
| @Test | ||
| public void testParentFIle() { |
| br.close(); | ||
| fs.close(); | ||
|
|
||
| fileStatus = new FileStatus(12L, true, 60, 120l, 180L, new Path(fs.getName())); |
There was a problem hiding this comment.
why use URI (fs.getName()) to create FileStatus?
| import java.io.OutputStream; | ||
| import java.io.OutputStreamWriter; | ||
|
|
||
| import static java.lang.System.out; |
There was a problem hiding this comment.
suggest to remove unused import.
| import java.io.OutputStream; | ||
| import java.io.OutputStreamWriter; | ||
|
|
||
| import static java.lang.System.out; |
There was a problem hiding this comment.
suggest to remove unused import.
There was a problem hiding this comment.
@Hexiaoqiao can you have another look please
| } | ||
|
|
||
| @Test | ||
| public void testgetParentFile() { |
There was a problem hiding this comment.
uniform Naming for parameters: testGetParentFile?
|
@anubhav100 there are still some exception when run ut, pls ref: http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/616/consoleFull |
|
@Hexiaoqiao thats because we are writing the test cases for exception take a look here @OverRide public String getCanonicalPath() { |
|
LGTM |
anubhav100
changed the title
|
@Hexiaoqiao i renamed pull request |
anubhav100
changed the title
|
@anubhav100 the below info only be template for reminding to check everything, the PR description doesn't need to include , please remove it. Be sure to do all of the following to help us incorporate your contribution Make sure the PR title is formatted like: Make sure tests pass via mvn clean verify. (Even better, enable Replace <Jira issue #> in the title with the actual Jira issue If this contribution is large, please file an Apache Testing done Please provide details on
|
|
@chenliang613 i removed template from pr thanks |
|
@chenliang613 i removed template from pr please merge it |
|
LGTM |
Prepare environment in docker to deploy kubernetes
No description provided.