-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CARBONDATA-368]Imporve performance of dataframe loading #278
Conversation
Some testcase failed after rebase to master |
I have fix test case error. |
format: SimpleDateFormat, | ||
level: Int = 1): String = { | ||
value == null match { | ||
case true => serializationNullFormat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use if else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
please rebase |
Rebase done |
DataLoadPartitionCoalescer concurrently read dataframe
@@ -548,77 +552,53 @@ class DataFrameLoaderRDD[K, V]( | |||
override protected def getPartitions: Array[Partition] = firstParent[Row].partitions | |||
} | |||
|
|||
class PartitionIterator(partitionIter: Iterator[DataLoadPartitionWrap[Row]], | |||
carbonLoadModel: CarbonLoadModel, | |||
context: TaskContext) extends JavaRddIterator[JavaRddIterator[Array[String]]] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -932,7 +942,8 @@ object CarbonDataRDDFactory { | |||
loadDataFile() | |||
} | |||
val newStatusMap = scala.collection.mutable.Map.empty[String, String] | |||
status.foreach { eachLoadStatus => | |||
if (status.nonEmpty) { | |||
status.foreach { eachLoadStatus => | |||
val state = newStatusMap.get(eachLoadStatus._1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
} | ||
return null; | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Move graf‘s json.template to bootstrap
support concurrently reading dataframe in CSVInput step
fix bug for reading dataframe in kettle thread
customize DataLoadPartitionCoalescer to repartition input DataFrame without shuffle.