[CARBONDATA-269]change delete segment syntax #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay357089
force-pushed
the
masterparser
branch
2 times, most recently
from
a20c091
to
28ff611
Compare
Jay357089
changed the title
|
What is the new proposed syntax here? |
Jay357089
changed the title
| DELETE ~> SEGMENT ~> repsep(segmentId, ",") ~ (FROM ~> TABLE ~> | ||
| (ident <~ ".").? ~ ident) <~ | ||
| DELETE ~> FROM ~ TABLE ~> (ident <~ ".").? ~ ident ~ | ||
| (WHERE ~> SEGMENT ~> EQUAL ~> repsep(segmentId, ",")) <~ |
There was a problem hiding this comment.
I think its better to use segments in both places deleteLoadsByID , deleteLoadsByLoadDate to avoid confusion
Jay357089
force-pushed
the
masterparser
branch
from
28ff611
to
fbbf0e0
Compare
Jay357089
force-pushed
the
masterparser
branch
from
fbbf0e0
to
0f45d51
Compare
|
@ManoharVanam done and CI passed. http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/315/ |
|
Please update all related .md files . |
|
need more discussion. close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CARBONDATA-269