Skip to content

Eip Sample: default period is restored, when created via ProcessorDefinition.#21632

Open
JiriOndrusek wants to merge 1 commit intoapache:mainfrom
JiriOndrusek:samepleDefault
Open

Eip Sample: default period is restored, when created via ProcessorDefinition.#21632
JiriOndrusek wants to merge 1 commit intoapache:mainfrom
JiriOndrusek:samepleDefault

Conversation

@JiriOndrusek
Copy link
Contributor

@JiriOndrusek JiriOndrusek commented Feb 27, 2026

fixes https://issues.apache.org/jira/browse/CAMEL-23097

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

@github-actions github-actions bot added the core label Feb 27, 2026
@github-actions
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@JiriOndrusek JiriOndrusek changed the title fixes CAMEL-23097. Sample default period is restored when created via fixes CAMEL-23097. Sample default period is restored (created via ProcessorDefinition) Feb 27, 2026
@JiriOndrusek JiriOndrusek changed the title fixes CAMEL-23097. Sample default period is restored (created via ProcessorDefinition) Eip Sample: default period is restored, when created via ProcessorDefinition. Feb 27, 2026
Copy link
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this - but the EIPs should not set values that at the default values. Defaults should be null.

So the fix is that the SamplingReifier has mistakenly 1 as the default instead of 1000

        long time = parseDuration(definition.getSamplePeriod(), 1);

Should be

        long time = parseDuration(definition.getSamplePeriod(), 1000);

@JiriOndrusek
Copy link
Contributor Author

I see thanks, I'll fix this on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants