Eip Sample: default period is restored, when created via ProcessorDefinition.#21632
Open
JiriOndrusek wants to merge 1 commit intoapache:mainfrom
Open
Eip Sample: default period is restored, when created via ProcessorDefinition.#21632JiriOndrusek wants to merge 1 commit intoapache:mainfrom
JiriOndrusek wants to merge 1 commit intoapache:mainfrom
Conversation
… ProcessorDefinition
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
requested changes
Feb 27, 2026
Contributor
davsclaus
left a comment
There was a problem hiding this comment.
Thanks for spotting this - but the EIPs should not set values that at the default values. Defaults should be null.
So the fix is that the SamplingReifier has mistakenly 1 as the default instead of 1000
long time = parseDuration(definition.getSamplePeriod(), 1);
Should be
long time = parseDuration(definition.getSamplePeriod(), 1000);
Contributor
Author
|
I see thanks, I'll fix this on Monday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://issues.apache.org/jira/browse/CAMEL-23097
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.