Skip to content

Added camel-kafka-connector Binaries releases. #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

valdar
Copy link
Member

@valdar valdar commented Dec 9, 2020

The intend is to create a Binaries section for camel kafka connector in the download page auto magically linking to the content ASF svn

@zregvart
Copy link
Member

zregvart commented Dec 9, 2020

Thanks, this will do the desired effect, but we also need binaries for 0.6.1 uploaded to dist, otherwise we'll serve a broken link.

Either that or we need to modify the template and add make this conditional. For example we do this for sha1 vs sha512 hash files:

{{/* after 2018-11-10 we started using SHA512 */}}
{{ $sha1_cutoff := time "2018-11-10" }}

{{ $hash_extension := ".sha512" }}
{{ if le $release_note.Date $sha1_cutoff }}
{{ $hash_extension = ".sha1" }}
{{ end }}

A bit more proper way of making this conditional would be to add the condition to the release-categories.yaml, i.e. something like from: 2021-01-01, and choose in the template based on that and the release date. This would then work for the sha1/sha512 and for future cases when we change something about the dist.

@valdar
Copy link
Member Author

valdar commented Dec 18, 2020

Closing as no more needed see: https://issues.apache.org/jira/browse/INFRA-21181

@valdar valdar closed this Dec 18, 2020
@valdar valdar deleted the addCKCbinaries branch December 18, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants