Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override Camel's testcontainer version and upgrade to 1.15.1 due to GH issue #990 #991

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Override Camel's testcontainer version and upgrade to 1.15.1 due to GH issue #990 #991

merged 1 commit into from
Feb 9, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Feb 9, 2021

Please don't merge yet. POC for GH issue #990

oscerd
oscerd approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be for free once we upgrade to 3.8.0, but yeah let's do it

@orpiske
Copy link
Contributor Author

orpiske commented Feb 9, 2021

@oscerd thanks. I'll merge this one and will revert in case of problems. We might also need #989 to reduce the amount of false negatives we are having atm.

@oscerd
Copy link
Contributor

oscerd commented Feb 9, 2021

Thanks for this

valdar
valdar approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@valdar valdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@orpiske orpiske merged commit 88d6980 into apache:master Feb 9, 2021
@orpiske
Copy link
Contributor Author

orpiske commented Feb 9, 2021

Looks good, merged. Thanks folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valdar valdar valdar approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orpiske @oscerd @valdar