Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#873 initial cxf Source/Sink connectors test #940

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

ffang
Copy link
Contributor

@ffang ffang commented Jan 29, 2021

No description provided.

Copy link
Member

@valdar valdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked this as request changes to keep track of the suggestions @orpiske gave.

@ffang
Copy link
Contributor Author

ffang commented Feb 8, 2021

@orpiske revised accordingly per your feedback. Thanks!

Copy link
Contributor

@orpiske orpiske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ffang! LGTM.

@ffang ffang merged commit 224ae8f into apache:master Feb 9, 2021
@ffang ffang deleted the cxf-itests-pr branch February 9, 2021 15:34
@ffang
Copy link
Contributor Author

ffang commented Feb 9, 2021

Merged, thanks guys!

orpiske pushed a commit to orpiske/camel-kafka-connector that referenced this pull request Feb 12, 2021
* apache#873 initial cxf Source/Sink connectors test

* revise according to feedback
orpiske pushed a commit that referenced this pull request Feb 15, 2021
* #873 initial cxf Source/Sink connectors test

* revise according to feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants