Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 14 changes #918

Merged
merged 7 commits into from
Jan 28, 2021
Merged

Java 14 changes #918

merged 7 commits into from
Jan 28, 2021

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jan 25, 2021

I am opening this draft PR with some of the changes I had to do in order to build the project with Java 14.

Let's not merge this one yet ... I think it needs some review because of several plugin upgrades.

@orpiske orpiske requested review from valdar and oscerd January 25, 2021 09:39
@orpiske orpiske mentioned this pull request Jan 25, 2021
3 tasks
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can try to upgrade groovy to 3.x

@orpiske
Copy link
Contributor Author

orpiske commented Jan 25, 2021

@lburgazzoli @oscerd I tried to be conservative with the upgrades, but if you are comfortable with that, we can try going with Groovy 3.x. I will modify this later today and run some builds for testing.

@lburgazzoli
Copy link
Contributor

@lburgazzoli @oscerd I tried to be conservative with the upgrades, but if you are comfortable with that, we can try going with Groovy 3.x. I will modify this later today and run some builds for testing.

I think Camel is already on Groovy 3.x so it should be ok, I'm also using Groovy 3.x since long time in camel-k-runtime and so fare everything seems good

@apupier
Copy link
Contributor

apupier commented Jan 25, 2021

what about adding the JDK 14 in th ebuild matrix? it will allow to see on this PR directly if it is building fine and also detect regressions.

@orpiske
Copy link
Contributor Author

orpiske commented Jan 25, 2021

what about adding the JDK 14 in th ebuild matrix? it will allow to see on this PR directly if it is building fine and also detect regressions.

+1 from me. I'll do that.

@oscerd
Copy link
Contributor

oscerd commented Jan 26, 2021

Seems to be ok.

@orpiske
Copy link
Contributor Author

orpiske commented Jan 26, 2021

Seems to be ok.

I agree. It looks OK so far. I have run a few additional tests on a CI I have @ home and everything seemed to run OK. I'll remove the draft flag on the PR.

@orpiske orpiske marked this pull request as ready for review January 26, 2021 07:31
@orpiske orpiske changed the title [POC] Java 14 changes Java 14 changes Jan 26, 2021
@claudio4j
Copy link
Contributor

After Java 9 there is the release parameter, shouldn't use it for Java 14 in the maven-compiler-plugin configuration section, instead of source/target ? Example:

<configuration>
    <release>14</release>
</configuration>

@oscerd
Copy link
Contributor

oscerd commented Jan 27, 2021

No, because we need to support java 8 as base. Pointing directly java 14 will drop jdk8

@valdar valdar added the WIP Work in Progress PRs: do not merge them! label Jan 27, 2021
@oscerd
Copy link
Contributor

oscerd commented Jan 28, 2021

@orpiske if you are ok, we can merge.

@orpiske
Copy link
Contributor Author

orpiske commented Jan 28, 2021

@orpiske if you are ok, we can merge.

Thanks @oscerd, @lburgazzoli, @apupier and @claudio4j for the review and comments. I'll merge this and we can fine tune later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress PRs: do not merge them!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants