-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 14 changes #918
Java 14 changes #918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can try to upgrade groovy to 3.x
@lburgazzoli @oscerd I tried to be conservative with the upgrades, but if you are comfortable with that, we can try going with Groovy 3.x. I will modify this later today and run some builds for testing. |
I think Camel is already on Groovy 3.x so it should be ok, I'm also using Groovy 3.x since long time in camel-k-runtime and so fare everything seems good |
what about adding the JDK 14 in th ebuild matrix? it will allow to see on this PR directly if it is building fine and also detect regressions. |
+1 from me. I'll do that. |
Seems to be ok. |
I agree. It looks OK so far. I have run a few additional tests on a CI I have @ home and everything seemed to run OK. I'll remove the draft flag on the PR. |
After Java 9 there is the
|
No, because we need to support java 8 as base. Pointing directly java 14 will drop jdk8 |
@orpiske if you are ok, we can merge. |
Thanks @oscerd, @lburgazzoli, @apupier and @claudio4j for the review and comments. I'll merge this and we can fine tune later if needed. |
I am opening this draft PR with some of the changes I had to do in order to build the project with Java 14.
Let's not merge this one yet ... I think it needs some review because of several plugin upgrades.