Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE on Windows for Catalog initialization #697 #698

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Nov 10, 2020

path inside bundles are always using "/", it is a resource path, not a
file path. i tis then not using a file separator.

Signed-off-by: Aurélien Pupier apupier@redhat.com

path inside bundles are always using "/", it is a resource path, not a
file path. i tis then not using a file separator.

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@oscerd
Copy link
Contributor

oscerd commented Nov 10, 2020

This was introduced here: 0c6871f

@apupier
Copy link
Contributor Author

apupier commented Nov 10, 2020

This was introduced here: 0c6871f

not exactly as it was not working at all with a built jar before this commit. It has never worked on Windows with a built jar.

@oscerd
Copy link
Contributor

oscerd commented Nov 10, 2020

In the beginning this was just a PoC to provide something, it wasn't developed to be a jar, but just to return something to consume. Also Windows is not really our main focus.

@apupier
Copy link
Contributor Author

apupier commented Nov 10, 2020

In the beginning this was just a PoC to provide something, it wasn't developed to be a jar,

it is consumed as a jar. It must work as a jar.
Having the Proof of concept, even if not working as a jar, was a great start. Now, we can incrementally improve it to support more cases.

Also Windows is not really our main focus.

for the catalog, it is an important target given that it is used during development.
I do not have figures of OS usage for VS Code side but for Eclipse Fuse Tooling, where it is also used, 80% is Windows.

@oscerd oscerd merged commit 6c97e2c into apache:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants