Catalog: expose an API for consuming connectors catalog metadata and options #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options, some little adjustments
apupier
reviewed
Oct 9, 2020
| return connectorsName; | ||
| } | ||
|
|
||
| public static Map<String, CamelKafkaConnectorModel> getConnectorsModel() { |
There was a problem hiding this comment.
why this method is static?
If accessed before an instanciation of the class happened, it will return an empty value.
There was a problem hiding this comment.
ok, I will provide a PR to remove the static
There was a problem hiding this comment.
It's already done and merged
apupier
reviewed
Oct 9, 2020
| public String getConnectorAsJson(String connectorName) { | ||
| String result = null; | ||
| try { | ||
| result = Files.lines(Paths.get(CONNECTORS_DIR + File.separator + connectorName + ".json")).parallel() // for |
There was a problem hiding this comment.
I think that accessing this way doesn't work with a bundled jar. It is working only in development mode with an exploded folder. Next to use some getResourceAsStream methods
I will have a look to provide PR
There was a problem hiding this comment.
We can also use the catalog helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542