-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog: Rename the json file to reflect the id and connectors.properties content #536
Conversation
…ties content - removed old named json
…ties content - removed old named json in connectors subfolders
…ties content - set the name in the form camel-aws2-s3-sink/source.json
…ties content - regeneration
"camel.sink.endpoint.headerFilterStrategy": { | ||
"name": "camel.sink.endpoint.headerFilterStrategy", | ||
"description": "To use a custom HeaderFilterStrategy to filter header to and from Camel message.", | ||
"defaultValue": "null", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't a problem to make the difference between the null
as String
and no default value?
I'm guessing here that it means there is no default value defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is no default value when it's null. This is something coming from the how kafka connect define the options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it means that we cannot define a default value which is the null String? or there are ways to escape it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can improve the connector aurogeneration for this. @valdar cc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oscerd it seems that we can use ConfigDef.NO_DEFAULT_VALUE
kafka connect side to distinguish between no default value and null
as default value. I am investigating if that information is available in the vanilla camel catalog that we process to generate connectors.
Fixes #534