Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog: Rename the json file to reflect the id and connectors.properties content #536

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Oct 7, 2020

Fixes #534

oscerd added 4 commits October 7, 2020 18:34
…ties content - removed old named json in connectors subfolders
…ties content - set the name in the form camel-aws2-s3-sink/source.json
"camel.sink.endpoint.headerFilterStrategy": {
"name": "camel.sink.endpoint.headerFilterStrategy",
"description": "To use a custom HeaderFilterStrategy to filter header to and from Camel message.",
"defaultValue": "null",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a problem to make the difference between the null as String and no default value?

I'm guessing here that it means there is no default value defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is no default value when it's null. This is something coming from the how kafka connect define the options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means that we cannot define a default value which is the null String? or there are ways to escape it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can improve the connector aurogeneration for this. @valdar cc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscerd it seems that we can use ConfigDef.NO_DEFAULT_VALUE kafka connect side to distinguish between no default value and null as default value. I am investigating if that information is available in the vanilla camel catalog that we process to generate connectors.

@oscerd oscerd deleted the issue-534 branch October 9, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalog: Rename the json file to reflect the id and connectors.properties content
3 participants