Fixes for edge cases #373
Merged
Fixes for edge cases #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using local-strimzi-container, due to having a difference startup/shutdown cycle, the startup would fail due to the container name already being in use. This fix this issue.
…outs in systems already overloaded with the test execution
The protocol is already set in the TestSNSConfiguration.
- simplified assertions - removed redundant @test annotation were @RepeatedTest is present
orpiske
force-pushed
the
fix-test-edge-cases
branch
from
05df931 to
10451f2
Compare
oscerd
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of edge cases on the tests: using local strimzi containers, running tests on a slow system, etc.
Also disables a flaky test on AWS SNS that needs further investigation