Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tests for JDBC sink #316

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Added tests for JDBC sink #316

merged 1 commit into from
Jul 9, 2020

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented Jul 8, 2020

No description provided.

oscerd
oscerd requested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the mariadb driver should be provided, not included as dependency

@oscerd oscerd merged commit e385af8 into apache:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orpiske @oscerd