-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds integration tests for Salesforce #247
Conversation
a78a8aa
to
4932ca0
Compare
Ah, thanks a lot @orpiske! Very nice and needed contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be possible to add the documented steps on a readme?
Thanks for the review! I will include more details about how to run these tests :) |
This includes the automation to create the test data on Salesforce by using the sfdx CLI client
This includes the automation to verify and delete the test data on Salesforce by using the sfdx CLI client
4932ca0
to
0fb7cfa
Compare
I added the details required to setup the Salesforce account, with some links to the documentation and the steps required to run the tests. Does it look OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds some simple integration tests for Salesforce. Not all functionality
is covered, but I think it provides an initial infrastructure for future tests.
Currently covered:
The tests do not run by default. Because the Salesforce DTOs are required and
also some setup is required on Salesforce, the tests need to be enabled using
a maven profile (-Psalesforce) along with the required properties for the test
execution (all documented on the test classes).
Once this initial setup is done, the tests can run automatically.