Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integration tests for Salesforce #247

Merged
merged 3 commits into from
May 28, 2020

Conversation

orpiske
Copy link
Contributor

@orpiske orpiske commented May 27, 2020

This adds some simple integration tests for Salesforce. Not all functionality
is covered, but I think it provides an initial infrastructure for future tests.

Currently covered:

  • Source: basic data consumption tests + change data capture tests
  • Sink: createSObject operation

The tests do not run by default. Because the Salesforce DTOs are required and
also some setup is required on Salesforce, the tests need to be enabled using
a maven profile (-Psalesforce) along with the required properties for the test
execution (all documented on the test classes).

Once this initial setup is done, the tests can run automatically.

@orpiske orpiske force-pushed the salesforce-camel-3.3 branch from a78a8aa to 4932ca0 Compare May 27, 2020 13:31
@valdar
Copy link
Member

valdar commented May 27, 2020

Ah, thanks a lot @orpiske! Very nice and needed contribution.

Copy link
Member

@valdar valdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be possible to add the documented steps on a readme?

@orpiske
Copy link
Contributor Author

orpiske commented May 28, 2020

Ah, thanks a lot @orpiske! Very nice and needed contribution.

Thanks for the review! I will include more details about how to run these tests :)

orpiske added 3 commits May 28, 2020 15:16
This includes the automation to create the test data on Salesforce by using the sfdx CLI client
This includes the automation to verify and delete the test data on Salesforce by using the sfdx CLI client
@orpiske orpiske force-pushed the salesforce-camel-3.3 branch from 4932ca0 to 0fb7cfa Compare May 28, 2020 13:17
@orpiske
Copy link
Contributor Author

orpiske commented May 28, 2020

I added the details required to setup the Salesforce account, with some links to the documentation and the steps required to run the tests.

Does it look OK?

Copy link
Contributor

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oscerd oscerd merged commit 88f8cd4 into apache:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants