Improved CamelSourceTaskTest

[fvaleri]

Merged last commit from @valdar with my previous refactoring. There is no sleep time and I have also removed timer delay=0 option that adds about 30s delay or more. Now, on my machine, the whole suite runs consistently in about 8s vs 38s of previous version.

[oscerd]

Tests on CI are failing.

[fvaleri]

Yes, let me fix testSourcePollingTimeout and push force.

[oscerd]

Just a question.

cc @valdar

[valdar]

@fvaleri the amount of time spared is largely due to the fact that now 100 messages are sent instead of 999. I agree that at present 100 should do since in 1 millisecond is unlikely that all of them will be consumed even on a faster machine than ours (we don't know what future will hold though :) )

[fvaleri]

@fvaleri the amount of time spared is largely due to the fact that now 100 messages are sent instead of 999. I agree that at present 100 should do since in 1 millisecond is unlikely that all of them will be consumed even on a faster machine than ours (we don't know what future will hold though :) )

Based on my tests, the difference between 100 and 999 is negligible as it is a tight loop (so I will revert back to 999). What really slow down is the use of timer's delay option, even if we set 0 or -1, there is about 30s delay. Then, using a classic fori instead of Stream's foreach to send batch test records is also faster.

[valdar]

@fvaleri ah that is weird, surely can be explained digging into camel timer component, but I agree that we can implement the same tests avoiding timer delay option.

[valdar]

LGTM

[valdar]

@fvaleri thanks a lot for the PR and the patience. I am merging this with failing checks because they seem due to Github actions problems.

[fvaleri]

@valdar no problem at all, I'm happy to contribute. Thanks.