Skip to content

fix(dep): Update mergo to prod ready v1 dario.cat/mergo #6169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

gansheer
Copy link
Contributor

Dependabot has been failing due to the change in mergo url: https://github.com/darccio/mergo?tab=readme-ov-file#important-notes

  • setting language native (en) before running test as it does not works on Linux with other language

Release Note

fix(dep): Update mergo to prod ready v1 dario.cat/mergo

@gansheer gansheer marked this pull request as draft May 27, 2025 08:06
@gansheer gansheer marked this pull request as ready for review May 27, 2025 08:09
@gansheer gansheer requested a review from squakez May 27, 2025 08:39
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure it is a good idea to keep using this dependency. I think it is used in some old merging stuff that could be probably dismissed soon. If there is no real urgency, I'd keep using the old dependency and let it go the feature using it asap.

@gansheer
Copy link
Contributor Author

gansheer commented Jun 2, 2025

It has been failing in dependabot : https://github.com/apache/camel-k/actions/workflows/dependabot/dependabot-updates. It has been failing a long time...

@gansheer gansheer requested a review from squakez June 2, 2025 13:35
@squakez squakez merged commit 22bd972 into apache:main Jun 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants