[CALCITE-4948] Revert Elasticsearch to 7.10.2 #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extra maven repository.
vlsi
reviewed
Dec 17, 2021
Comment on lines
40
to
-47
| testImplementation("org.codelibs.elasticsearch.module:lang-painless") | ||
| testImplementation("org.codelibs.elasticsearch.module:scripting-painless-spi") |
There was a problem hiding this comment.
Is org.codelibs an authentic source of the dependencies? C
It looks like they publish non AL2 code as if it was AL2.
Should we use org.elasticsearch.plugin:elasticsearch-scripting-painless-spi instead?
There was a problem hiding this comment.
I've opened a separate ticket to evaluate since we've had the org.codelibs.elasticsearch.module:lang-painless dependency for 2+years. For reference, it looks like this comment was lost when we migrated from maven to gradle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove extra maven repository.