[CALCITE-3207] Fail to convert Join RelNode with like condition to sql statement

[wojustme]

Calcite cannot convert rel node to sql statement, which case is the condition of join is 'like' expression.

[chunweilei]

Please change the commit message since 'fix' should better not appear.
How about "Fail to convert Join RelNode with like condition to sql statement"?

[danny0405]

@wojustme Seems a little weird that why we should enumerate all these SqlKind here, which is error prone, can you please also check other operator (are there else operators missing)?

[wojustme]

@chunweilei thx for your comment. I change commit message for describe the problem.

[wojustme]

@danny0405 THX for your reminder, I will check other operator later.

[wojustme]

Hi @danny0405
I rethink this problem. Should we handle the condition in join syntax according to operator, not according to sqlkind.
If this direction is correct, I could try to fix it.

[danny0405]

Thanks @wojustme , i recheck the code the it seems there is no common way to enumerate all these condition operators, per the like operator, it is a SqlSpecialOperator, so i think this fix is ok.

I'm + 1 for this

[wojustme]

@danny0405
Thank you for reviewing my code.
I think there is more common way to handle this case , when condition syntax is in the join expression, just like the handler of the filter expression.
If my thoughts is wrong, Please tell me to correct my mistake.

[danny0405]

@danny0405
Thank you for reviewing my code.
I think there is more common way to handle this case , when condition syntax is in the join expression, just like the handler of the filter expression.
If my thoughts is wrong, Please tell me to correct my mistake.

I think the main reason that the SqlImplementor needs to handle the join condition separately is that the Join has 2 Context[1], and each binary operators needs to figure out which context their operands references belong to, so sync the logic with Filter seems not a good idea.
[1]

calcite/core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

Line 422 in 689a5bb

public abstract static class Context {

[danny0405]

Colse to retrigger tests.

[wojustme]

@danny0405
Yeah, your view is right.
Thank you for your advice. I learned more from talking with you.

[wojustme]

Hi @chunweilei
I have to change the commit, please to review my pr again.