Skip to content

[CALCITE-3163] AbstractCursor#convertValue() now adheres to JDBC specification #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ppanopticon wants to merge 1 commit into from
Closed

[CALCITE-3163] AbstractCursor#convertValue() now adheres to JDBC specification #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,8 +1318,9 @@ private Object convertValue() throws SQLException {
return componentAccessor.getInt();
case Types.BIGINT:
return componentAccessor.getLong();
case Types.FLOAT:
case Types.REAL:
return componentAccessor.getFloat();
case Types.FLOAT:
Comment on lines -1321 to +1323

@zabetak zabetak Feb 19, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks reasonable but I was thinking that it would be nice to have some tests to guard against future regressions. Maybe in ArrayTypeTest?

@asolimando asolimando Feb 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, unfortunately ArrayTypeTest being based on hsqldb, won't work as-is, because hsqldb maps Double, Real and Float to Java double (see here).

I tried and indeed a CREATE TABLE $table (id integer, vals REAL ARRAY) statement creates a table (INTEGER, DOUBLE ARRAY).

Either we find an "easy" way to use another DB in those tests, or we need to find another location, I will have a look during the weekend.

@asolimando asolimando Feb 20, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have managed to add unit tests, I have opened a complementing PR: #139

case Types.DOUBLE:
return componentAccessor.getDouble();
case Types.ARRAY:
Expand Down