Adds option to remove thread check on sqlite persister for streamlit#286
Merged
Conversation
b517727 to
31a9c93
Compare
skrawcz
requested changes
Jul 29, 2024
skrawcz
left a comment
Contributor
There was a problem hiding this comment.
Just go ahead and expose passing in connect kwargs. That will simplify things. E.g. for disabling the check for the same thread see kwargs you can pass to connect...
31a9c93 to
12f68a1
Compare
Streamlit uses multiple threads for execution, which can mess with the sqlite persister, which wants to be all on the same thread. This allows it to bypass the thread check with an option.
12f68a1 to
7de5d8f
Compare
skrawcz
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlit uses multiple threads for execution, which can mess with the sqlite persister, which wants to be all on the same thread. This allows it to bypass the thread check with an option.
Checklist