Skip to content

Expose kwargs redis#283

Merged
skrawcz merged 3 commits into
mainfrom
expose_kwargs_redis
Jul 24, 2024
Merged

Expose kwargs redis#283
skrawcz merged 3 commits into
mainfrom
expose_kwargs_redis

Conversation

@skrawcz

@skrawcz skrawcz commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

This is required if you want SSL, or changing the protocol, etc.

Changes

  • redis persister constructor
  • mongodb persister constructor

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

This is required if you want SSL, or changing the protocol, etc.
@skrawcz skrawcz force-pushed the expose_kwargs_redis branch from 77dc399 to 2a1974e Compare July 24, 2024 03:44
skrawcz added 2 commits July 23, 2024 20:45
So that extra kwargs can be passed in.
To push kwargs exposure for redis & mongo persisters.
@skrawcz skrawcz merged commit e32dd29 into main Jul 24, 2024
@skrawcz skrawcz deleted the expose_kwargs_redis branch July 24, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant