feat: add a service option to disable check eovercrowded on server side #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenBright
requested changes
Sep 30, 2024
|
What is the usage scenario of this feature? |
|
@wwbmmm we have some control-frame methods which we hope will not fail in case of eovercrowded. |
|
@chenBright please help check |
chenBright
approved these changes
Oct 8, 2024
chenBright
requested changes
Oct 8, 2024
|
@chenBright http2 needed as well? |
wwbmmm
reviewed
Oct 12, 2024
src/brpc/server.cpp
Outdated
| @@ -794,6 +795,7 @@ static bool OptionsAvailableOverRdma(const ServerOptions* opt) { | |||
| #endif | |||
|
|
|||
| static AdaptiveMaxConcurrency g_default_max_concurrency_of_method(0); | |||
| static bool g_default_ignore_eovercrowded(false); | |||
http2 also use ProcessHttpRequest. Protocols that use the is_overcrowded function need as well. |
|
@wwbmmm @chenBright all done |
|
LGTM |
superhail
changed the title
superhail
changed the title
superhail
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary: Sometimes we need to disable check eovercrowded for some methods
What is changed and the side effects?
Changed: add a method/service level option to disable check eovercrowded on server side
Side effects:
Performance effects(性能影响): zero/or little
Breaking backward compatibility(向后兼容性): no breaking
Check List: