Skip to content

[fix]compile error of the file native_io_jni.c for the env jdk11 & windows #4665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zymap merged 1 commit into from
Oct 22, 2025
Merged

[fix]compile error of the file native_io_jni.c for the env jdk11 & windows #4665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion native-io/src/main/native-io-jni/cpp/native_io_jni.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,16 @@
*/
#define _GNU_SOURCE

#include <jni.h>
#include <errno.h>
#include <fcntl.h>
#include <stdlib.h>
#include <string.h>
#ifdef _WIN32
#include <io.h>
#else
#include <unistd.h>
#endif

#include <org_apache_bookkeeper_common_util_nativeio_NativeIOJni.h>

Expand Down Expand Up @@ -165,7 +170,14 @@ JNIEXPORT jint JNICALL
Java_org_apache_bookkeeper_common_util_nativeio_NativeIOJni_fsync(JNIEnv * env,
jclass clazz,
jint fd) {
int res = fsync(fd);
int res;

// Guarantee compatibility for winsows.
#ifdef _WIN32
res = _commit((int)fd);
#else
res = fsync((int)fd);
#endif

if (res == -1) {
throwExceptionWithErrno(env, "Failed to fsync");
Expand Down
Loading