[improve][conf] Change the default value of readOnlyModeOnAnyDiskFullEnabled to true#4520
Merged
StevenLuMT merged 3 commits intoDec 2, 2024
Conversation
Contributor
|
I agree with this change but I cannot find the discussion on the mailing list |
Contributor
Author
Thank you for your support. I apologize for not starting the discussion on the mailing list earlier due to my busy schedule. I have just sent out the discussion email, and you can find it here: https://lists.apache.org/thread/cvspxb4d1ryy4wo1j2k5r1qr9fcjsd42 |
AnonHxy
approved these changes
Nov 22, 2024
hezhangjian
approved these changes
Nov 22, 2024
Member
|
@lhotari currently, is there any labels to track release note updates? |
lhotari
added
the
release/important-notice
Member
Member
https://github.com/apache/bookkeeper/actions/runs/11605956158/job/33595453553?pr=4520 |
StevenLuMT
reviewed
Nov 30, 2024
| @@ -182,7 +182,7 @@ extraServerComponents= | |||
| # to read-only mode and serve only read requests. When all disks recovered, | |||
| # the bookie will be converted to read-write mode.Otherwise it will obey the `readOnlyModeEnabled` behavior. | |||
| # By default this will be disabled. | |||
Member
There was a problem hiding this comment.
By default this will be enable.
StevenLuMT
approved these changes
Nov 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The #3212 import a feature: convert bookie to read-only mode when any ledger disks is full.
In our practice, we found that when the bookie disk is full, if it is not changed to Read Only mode, a large number of messages will fail to be written to the ledger disk. And because the bookie status is still available at this time, no alarm is given to the maintenance personnel, resulting in slow access for the maintenance personnel.
That feature has been in place for some time. It is safe to enable it default.
PS: It was mentioned in the PR discussion that an email discussion should be submitted, but no follow-up was done. [0]
[0] - https://github.com/apache/bookkeeper/pull/3212/files#r857122376
Changes
Change the default value of readOnlyModeOnAnyDiskFullEnabled to true