BP-68: Delete cookie as part of decommission API.#4500
Merged
Conversation
Member
|
It's http body or url param? or |
Contributor
Author
|
It is part of the body along with bookie_src.
Thanks,
Karthick
…On Thu, Sep 12, 2024 at 9:50 AM ZhangJian He ***@***.***> wrote:
It's http body or url param?
{
"delete_cookie": true
}
or
?delete_cookie=true
—
Reply to this email directly, view it on GitHub
<#4500 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMOQPNBEELKRF4CRDJXSNLZWEJA7AVCNFSM6AAAAABNPT2MR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGIZTQNZVGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dlg99
approved these changes
Sep 12, 2024
wenbingshen
approved these changes
Sep 13, 2024
wenbingshen
left a comment
wenbingshen
left a comment
Member
There was a problem hiding this comment.
LGTM. The default behavior is sufficient to maintain forward compatibility.
zymap
pushed a commit
that referenced
this pull request
Dec 5, 2025
Implement the logic in [BP-68:](#4500) Delete cookie as part of decommission API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
New BP for deleting cookie as part of bookkeeper decommission API
#4499
Proposal PR: WIP