Skip to content

Bump grpc from 1.56.0 to 1.64.0 to address CVE list#4344

Merged
hezhangjian merged 3 commits into
apache:masterfrom
hezhangjian:grpc-1-63
May 16, 2024
Merged

Bump grpc from 1.56.0 to 1.64.0 to address CVE list#4344
hezhangjian merged 3 commits into
apache:masterfrom
hezhangjian:grpc-1-63

Conversation

@hezhangjian

Copy link
Copy Markdown
Member

@hezhangjian hezhangjian changed the title Bump grpc from 1.56.0 to 1.63.0 address CVE list Bump grpc from 1.56.0 to 1.63.0 to address CVE list May 7, 2024
@hezhangjian
hezhangjian force-pushed the grpc-1-63 branch 3 times, most recently from 6a63b51 to 7d0d8c6 Compare May 7, 2024 01:24
@hezhangjian
hezhangjian requested review from hangc0276 and merlimat and removed request for merlimat May 7, 2024 01:28
@hezhangjian

Copy link
Copy Markdown
Member Author

@hangc0276

Copy link
Copy Markdown
Contributor

We need to be careful to upgrade grpc versions. Pulsar also uses grpc and the version needs to be sync and compatible

@hezhangjian

Copy link
Copy Markdown
Member Author

We need to be careful to upgrade grpc versions. Pulsar also uses grpc and the version needs to be sync and compatible

I agree. But bk should go first.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@hezhangjian

Copy link
Copy Markdown
Member Author

@lhotari please also take a look

@lhotari

lhotari commented May 16, 2024

Copy link
Copy Markdown
Member

@lhotari please also take a look

protobuf version should be upgraded at the same time to ensure that it's compatible with grpc. Pick the version that grpc uses.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@hezhangjian

Copy link
Copy Markdown
Member Author

@lhotari fixed, please take a look again. :)

@lhotari

lhotari commented May 16, 2024

Copy link
Copy Markdown
Member

@lhotari fixed, please take a look again. :)

We could also migrate to use protobuf-bom in dependencyManagement.

      <dependency>
        <groupId>com.google.protobuf</groupId>
        <artifactId>protobuf-bom</artifactId>
        <version>${protobuf.version}</version>
        <type>pom</type>
        <scope>import</scope>
      </dependency>

@lhotari

lhotari commented May 16, 2024

Copy link
Copy Markdown
Member

It looks like grpc 1.64.0 was released yesterday. Should we go directly to the latest release?

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hezhangjian hezhangjian changed the title Bump grpc from 1.56.0 to 1.63.0 to address CVE list Bump grpc from 1.56.0 to 1.64.0 to address CVE list May 16, 2024
@hezhangjian
hezhangjian force-pushed the grpc-1-63 branch 2 times, most recently from 421bb8b to 3728c91 Compare May 16, 2024 06:53
@hezhangjian

Copy link
Copy Markdown
Member Author

@lhotari I aggree change the dest version to 1.64.0. updated.

Signed-off-by: ZhangJian He <shoothzj@gmail.com>
@hezhangjian
hezhangjian merged commit c1cac07 into apache:master May 16, 2024
@hezhangjian
hezhangjian deleted the grpc-1-63 branch May 16, 2024 07:56
@hezhangjian

Copy link
Copy Markdown
Member Author

@lhotari I found owasp check is broken, it doesn't trigger when I change the pom.xml. do you have any advice?

owasp-dependency-check:
name: OWASP Dependency Check
runs-on: ubuntu-latest
timeout-minutes: 60
needs: [ 'build-and-license-check' ]
if: ${{ needs.build-and-license-check.outputs.need_owasp == 'true' }}

need_owasp:
- 'pom.xml'
- '**/pom.xml'
- 'src/owasp-dependency-check-false-positives.xml'
- 'src/owasp-dependency-check-suppressions.xml'

@hangc0276 hangc0276 added the dependencies Pull requests that update a dependency file label May 25, 2024
@hangc0276 hangc0276 added this to the 4.18.0 milestone May 25, 2024
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
lhotari pushed a commit that referenced this pull request Apr 16, 2025
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
(cherry picked from commit c1cac07)
priyanshu-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 11, 2025
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
(cherry picked from commit c1cac07)
(cherry picked from commit 089bdae)
sandeep-ctds pushed a commit to datastax/bookkeeper that referenced this pull request Jul 22, 2025
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
(cherry picked from commit c1cac07)
(cherry picked from commit 089bdae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/branch-4.17 dependencies Pull requests that update a dependency file release/4.17.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants