Fix deletedLedgers count#4026
Merged
Merged
Conversation
Contributor
Author
hangc0276
approved these changes
Jul 17, 2023
hangc0276
pushed a commit
that referenced
this pull request
Aug 17, 2023
(cherry picked from commit 3bf08fe)
hangc0276
added
cherry-picked/branch-4.14
release/4.14.8
and removed
release/4.14.9
labels
zymap
pushed a commit
that referenced
this pull request
Aug 29, 2023
(cherry picked from commit 3bf08fe)
zymap
pushed a commit
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 3bf08fe)
gaozhangmin
pushed a commit
to gaozhangmin/bookkeeper
that referenced
this pull request
Feb 20, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Fix deletedLedgers count. We should increase the
deletedLedgersin the loop, otherwise it's value will always be zeroChanges
Increase the
deletedLedgersin the loop