Skip to content

Fix read write request leak when executor throw RejectedExecutionException#4024

Merged
zymap merged 1 commit into
apache:masterfrom
lifepuzzlefun:fix_leak_when_executor_fail_to_execute_request
Aug 29, 2023
Merged

Fix read write request leak when executor throw RejectedExecutionException#4024
zymap merged 1 commit into
apache:masterfrom
lifepuzzlefun:fix_leak_when_executor_fail_to_execute_request

Conversation

@lifepuzzlefun

Copy link
Copy Markdown
Contributor

No description provided.

@horizonzy horizonzy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@hangc0276 hangc0276 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@AnonHxy AnonHxy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276

Copy link
Copy Markdown
Contributor

rerun failure checks

@hangc0276

Copy link
Copy Markdown
Contributor

@zymap Please help take a look at this PR, thanks.

zymap

This comment was marked as resolved.

@zymap zymap left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangc0276 hangc0276 closed this Aug 10, 2023
@hangc0276 hangc0276 reopened this Aug 10, 2023
@zymap
zymap merged commit 0b0fe0b into apache:master Aug 29, 2023
zymap pushed a commit that referenced this pull request Aug 29, 2023
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
(cherry picked from commit 0b0fe0b)
zymap pushed a commit that referenced this pull request Dec 7, 2023
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
(cherry picked from commit 0b0fe0b)
gaozhangmin pushed a commit to gaozhangmin/bookkeeper that referenced this pull request Feb 20, 2024
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Co-authored-by: wangjinlong <wangjinlong@zhihu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants