Skip to content

Recycle LongWrapper finally to avoid memory leak#4007

Merged
StevenLuMT merged 1 commit into
apache:masterfrom
AnonHxy:try_finally
Jul 10, 2023
Merged

Recycle LongWrapper finally to avoid memory leak#4007
StevenLuMT merged 1 commit into
apache:masterfrom
AnonHxy:try_finally

Conversation

@AnonHxy

@AnonHxy AnonHxy commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Descriptions of the changes in this PR:

Motivation

We should recycle LongWrapper in finally block to avoid memory leak. Beacuase flush() and removeDeletedLedgers() could throw Exception.

Changes

Recycle LongWrapper in finally block

@AnonHxy AnonHxy changed the title Recycle LongWrapper finally Recycle LongWrapper finally to avoid memory leak Jun 30, 2023

@horizonzy horizonzy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnonHxy

AnonHxy commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

rerun failure checks

@StevenLuMT StevenLuMT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@AnonHxy

AnonHxy commented Jul 5, 2023

Copy link
Copy Markdown
Contributor Author

rerun failure checks

@StevenLuMT
StevenLuMT merged commit 528f373 into apache:master Jul 10, 2023
zymap pushed a commit that referenced this pull request Aug 29, 2023
(cherry picked from commit 528f373)
zymap pushed a commit that referenced this pull request Dec 7, 2023
(cherry picked from commit 528f373)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants